Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Reply protocol definition and codec #717

Merged
merged 9 commits into from
Feb 9, 2024
Merged

Update Reply protocol definition and codec #717

merged 9 commits into from
Feb 9, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Feb 5, 2024

Initial draft PR to address SampleKind in replies as stated in #673.

To better support storages and future evolution, the body a Reply message is equaled to the body of a Push message.
Moreover, Consolidation is made first-class citizen (i.e. a flag) in Query/Reply messages.

@Mallets Mallets added breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) release Part of the next release labels Feb 5, 2024
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

2 similar comments
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets linked an issue Feb 5, 2024 that may be closed by this pull request
Review of the protocol #673
Closed
12 tasks
@Mallets Mallets mentioned this pull request Feb 7, 2024
Closed
12 tasks
@OlivierHecart
Copy link
Contributor

OlivierHecart commented Feb 8, 2024 •
edited
Loading

First review OK.
Note that the changes in zenoh/src/*.rs will conflict with the work done there: #714

@Mallets Mallets self-assigned this Feb 8, 2024
@Mallets Mallets changed the base branch from main to protocol_changes February 8, 2024 10:59
@Mallets Mallets marked this pull request as ready for review February 8, 2024 10:59
@Mallets Mallets mentioned this pull request Feb 8, 2024
Closed
5 tasks
@OlivierHecart OlivierHecart merged commit efe1135 into protocol_changes Feb 9, 2024
16 checks passed
@OlivierHecart OlivierHecart deleted the protocol_reply branch February 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierHecart OlivierHecart OlivierHecart approved these changes

Assignees

@Mallets Mallets

Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review of the protocol
3 participants
@Mallets @eclipse-zenoh-bot @OlivierHecart